sofa/webcrate

Fork 0

✨ Add the Web Share Target API #46

Merged

hkamran80 merged 2 commits from develop-share-target into master

2021-10-26 20:33:50 +02:00

hkamran80 commented

2021-10-24 20:59:24 +02:00

(Migrated from github.com)

This PR adds the Web Share Target API to WebCrate.

Discussed in #29 (comment) and #44.

This PR adds the Web Share Target API to WebCrate. Discussed in [#29 (comment)](https://github.com/WebCrateApp/webcrate/discussions/29#discussioncomment-1381791) and #44.

BetaHuhn commented

2021-10-25 08:10:38 +02:00

(Migrated from github.com)

Why the change to the copy-templates script?

Why the change to the `copy-templates` script?

hkamran80 commented

2021-10-25 19:58:09 +02:00

(Migrated from github.com)

I use macOS, and it wouldn't recognize the -r argument to cp.

While -R is posix well-defined, -r is not portable!
On Linux, in the GNU and BusyBox implementations of cp, -r and -R are equivalent.
On the other side, as you can read in the POSIX manual page of cp, -r behavior is implementation-defined.

Source: this Stack Exchange answer

I use macOS, and it wouldn't recognize the `-r` argument to `cp`. > While `-R` is posix well-defined, `-r` is not portable! > On Linux, in the GNU and BusyBox implementations of `cp`, `-r` and `-R` are equivalent. > On the other side, as you can read in the POSIX manual page of `cp`, `-r` behavior is implementation-defined. [Source: this Stack Exchange answer](https://unix.stackexchange.com/a/18718)

BetaHuhn commented

2021-10-25 20:21:14 +02:00

(Migrated from github.com)

Ah okay, makes sense. Didn't know that -r only works on Linux, thanks for the explanation and source!

Will merge this tomorrow and release it with a few other fixes later this or next week.

Ah okay, makes sense. Didn't know that `-r` only works on Linux, thanks for the explanation and source! Will merge this tomorrow and release it with a few other fixes later this or next week.

BetaHuhn (Migrated from github.com) approved these changes

2021-10-25 20:21:34 +02:00

hkamran80 commented

2021-10-25 20:37:49 +02:00

(Migrated from github.com)

No problem! Thank you!

❤️ 1

WebCrateBot commented

2021-11-01 15:56:02 +01:00

(Migrated from github.com)

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

:tada: This PR is included in version 1.4.1 :tada: The release is available on [GitHub release](https://github.com/WebCrateApp/webcrate/releases/tag/v1.4.1) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

No reviewers

BetaHuhn

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sofa/webcrate!46

No description provided.

Rows
Columns