Only 20 crates being shown on sidebar at once #39

Closed
opened 2021-09-16 01:10:21 +02:00 by cjbohlman · 5 comments
cjbohlman commented 2021-09-16 01:10:21 +02:00 (Migrated from github.com)

🏷️ WebCrate Version

v1.2.0

⚙️ Environment

Firefox

🐞 Describe the bug

I have about 25 crates in WebCrate. On the sidebar, I can only see 20 of them. I can still search for the other missing ones, but I'm not seeing a way to display them. Unsure if this limit is intentional or not.

📚 To Reproduce

  1. Add >20 crates
  2. Count number of crates in sidebar
  3. Hopefully find discrepancy

💡 Expected behavior

All crates would be included in sidebar.

📋 Additional context

No response

### 🏷️ WebCrate Version v1.2.0 ### ⚙️ Environment Firefox ### 🐞 Describe the bug I have about 25 crates in WebCrate. On the sidebar, I can only see 20 of them. I can still search for the other missing ones, but I'm not seeing a way to display them. Unsure if this limit is intentional or not. ### 📚 To Reproduce 1. Add >20 crates 2. Count number of crates in sidebar 3. Hopefully find discrepancy ### 💡 Expected behavior All crates would be included in sidebar. ### 📋 Additional context _No response_
BetaHuhn commented 2021-09-16 15:20:45 +02:00 (Migrated from github.com)

Hey, thanks for opening this issue!

This limit is intentional, but not for the sidebar. The API only returns 20 items per request by default and expects the client to use pagination for more (like it's used for links). For the sidebar this doesn't make sense and is something I overlooked.

Will fix this with the next release.

Hey, thanks for opening this issue! This limit is intentional, but not for the sidebar. The API only returns 20 items per request by default and expects the client to use pagination for more (like it's used for links). For the sidebar this doesn't make sense and is something I overlooked. Will fix this with the next release.
cjbohlman commented 2021-09-16 18:45:31 +02:00 (Migrated from github.com)

Thank you for looking into this! I'm loving the project so far :)

Thank you for looking into this! I'm loving the project so far :)
BetaHuhn commented 2021-09-16 18:53:09 +02:00 (Migrated from github.com)

No problem, glad you like it!

Will close this issue for now. Fix is already on the develop branch will be a part of the next release.

No problem, glad you like it! Will close this issue for now. Fix is already on the develop branch will be a part of the next release.
WebCrateBot commented 2021-09-21 17:22:25 +02:00 (Migrated from github.com)

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

:tada: This issue has been resolved in version 1.3.0 :tada: The release is available on [GitHub release](https://github.com/WebCrateApp/webcrate/releases/tag/v1.3.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:
BetaHuhn commented 2021-09-21 18:42:41 +02:00 (Migrated from github.com)

🎉 This issue has been resolved in version 1.3.0 🎉

Thanks Mr Robot!

@cjbohlman refer to the docs on how you can update to the latest version if you haven't already :)

> 🎉 This issue has been resolved in version 1.3.0 🎉 Thanks Mr Robot! @cjbohlman refer to the [docs](https://webcrate.app/docs/faq#how-are-updates-handled) on how you can update to the latest version if you haven't already :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sofa/webcrate#39
No description provided.