sofa/webcrate

Fork 0

fix: Update icon for change name button #38

New issue

Closed

opened 2021-09-15 16:42:52 +02:00 by BetaHuhn · 3 comments

BetaHuhn commented

2021-09-15 16:42:52 +02:00

(Migrated from github.com)

Discussed in https://github.com/WebCrateApp/webcrate/discussions/37

^{Originally posted by dzakki September 15, 2021}
i found ambiguous icon for button save change name. let's see what i have made to fix that bellow.

BEFORE
Screen Shot 2021-09-15 at 20 12 44

AFTER
Screen Shot 2021-09-15 at 20 13 05

i will do pull request after you approve to of this change

Originally created by @dzakki in #37

### Discussed in https://github.com/WebCrateApp/webcrate/discussions/37 <div type='discussions-op-text'> <sup>Originally posted by **dzakki** September 15, 2021</sup> i found ambiguous icon for button save **change name**. let's see what i have made to fix that bellow. **BEFORE** <img width="930" alt="Screen Shot 2021-09-15 at 20 12 44" src="https://user-images.githubusercontent.com/38948296/133431462-84092421-b357-45bd-a1e0-a08a5267ecfa.png"> <img width="907" alt="Screen Shot 2021-09-15 at 20 12 57" src="https://user-images.githubusercontent.com/38948296/133431476-af69705f-2e1a-404b-a022-09d892dc2604.png"> **AFTER** <img width="930" alt="Screen Shot 2021-09-15 at 20 13 05" src="https://user-images.githubusercontent.com/38948296/133431565-8d298738-0c39-403a-83c1-4b839764657a.png"> <img width="933" alt="Screen Shot 2021-09-15 at 20 13 17" src="https://user-images.githubusercontent.com/38948296/133431578-0f914c43-bc95-4542-ae5e-a4107e0b15b2.png"> i will do pull request after you approve to of this change</div> Originally created by @dzakki in [#37](https://github.com/WebCrateApp/webcrate/discussions/37)

BetaHuhn commented

2021-09-15 16:44:05 +02:00

(Migrated from github.com)

Ah yeah, that icon definitely needs changing. Thanks for reporting!

Instead of a floppy disk I'd prefer a normal check mark icon which is already used in other parts of the app. @dzakki, if you want to create a PR and change it to the check icon, go ahead!

Ah yeah, that icon definitely needs changing. Thanks for reporting! Instead of a floppy disk I'd prefer a normal check mark icon which is already used in other parts of the app. @dzakki, if you want to create a PR and change it to the [check](https://github.com/WebCrateApp/webcrate/blob/master/client/components/Icon/check.vue) icon, go ahead!

BetaHuhn commented

2021-09-16 15:27:30 +02:00

(Migrated from github.com)

Merged, thanks!

Will be a part of the next release.

Merged, thanks! Will be a part of the next release.

👍 1

WebCrateBot commented

2021-09-21 17:22:28 +02:00

(Migrated from github.com)

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

:tada: This issue has been resolved in version 1.3.0 :tada: The release is available on [GitHub release](https://github.com/WebCrateApp/webcrate/releases/tag/v1.3.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sofa/webcrate#38

No description provided.

Rows
Columns